Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt api.Document.onvisibilitychange to new events structure #15084

Merged
merged 3 commits into from
Mar 15, 2022

Conversation

queengooborg
Copy link
Collaborator

This PR adapts the visibilitychange event of the Document API to conform to the new events structure.

This PR adapts the visibilitychange event of the Document API to conform to the new events structure.
@queengooborg queengooborg added the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Feb 22, 2022
@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Feb 22, 2022
@queengooborg queengooborg removed the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Mar 7, 2022
@Elchi3
Copy link
Member

Elchi3 commented Mar 14, 2022

There is a conflict here that needs solving.

@Elchi3 Elchi3 merged commit aac2807 into mdn:main Mar 15, 2022
@queengooborg queengooborg deleted the api/Document/visibilitychange/events branch March 15, 2022 10:58
@foolip
Copy link
Collaborator

foolip commented Sep 22, 2022

@queengooborg I haven't looked closely, but according to #17854 the conflict was resolved incorrectly, undoing changes that had been made to onvisibilitychange. This can be seen in the original and final diffs of this PR:
7763b01
aac2807

It's being fixed in #17855, just mentioning it here in case it was an accident and you know of other cases where the same thing would have happened that need revisiting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants